Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change order of webdriver timeout checks #22698

Merged

Conversation

eschutho
Copy link
Member

SUMMARY

The slice-container elements are loaded even when the chart loading elements are also there, so I'm changing the order of the checks to make sure that we're not looking at the initial loading spinner, but rather the ones that appear alongside the slice-container ones while the db is fetching the data.

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #22698 (7b5d5f1) into master (5399365) will decrease coverage by 11.07%.
The diff coverage is 0.00%.

❗ Current head 7b5d5f1 differs from pull request most recent head b6a50b5. Consider uploading reports for the commit b6a50b5 to get more accurate results

@@             Coverage Diff             @@
##           master   #22698       +/-   ##
===========================================
- Coverage   67.07%   55.99%   -11.08%     
===========================================
  Files        1869     1869               
  Lines       71591    71591               
  Branches     7822     7822               
===========================================
- Hits        48018    40086     -7932     
- Misses      21544    29476     +7932     
  Partials     2029     2029               
Flag Coverage Δ
hive 52.59% <0.00%> (ø)
mysql ?
postgres ?
presto 52.49% <0.00%> (ø)
python 58.24% <0.00%> (-23.06%) ⬇️
sqlite ?
unit 51.49% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/webdriver.py 25.66% <0.00%> (-54.87%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/tags/core.py 4.54% <0.00%> (-95.46%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-90.91%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-87.88%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-84.00%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/create.py 30.61% <0.00%> (-69.39%) ⬇️
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-69.00%) ⬇️
... and 289 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eschutho eschutho force-pushed the elizabeth/change-webdriver-timeouts branch from 7b5d5f1 to b6a50b5 Compare January 13, 2023 00:57
Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eschutho eschutho merged commit 0a2fc9c into apache:master Jan 17, 2023
@eschutho eschutho deleted the elizabeth/change-webdriver-timeouts branch February 3, 2023 23:02
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants