Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(thumbnails): change default executor to logged in user #22801

Merged
merged 6 commits into from May 17, 2023

Conversation

villebro
Copy link
Member

@villebro villebro commented Jan 20, 2023

SUMMARY

This changes Thumbnails to execute as the currently logged in user by default, and fall back to the Selenium user for anonymous users (=when there is no logged in user). This option was introduced in #22328

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #22801 (6f4bcba) into master (5192925) will increase coverage by 1.60%.
The diff coverage is 100.00%.

❗ Current head 6f4bcba differs from pull request most recent head 6a69159. Consider uploading reports for the commit 6a69159 to get more accurate results

@@            Coverage Diff             @@
##           master   #22801      +/-   ##
==========================================
+ Coverage   66.70%   68.31%   +1.60%     
==========================================
  Files        1951     1951              
  Lines       75385    75385              
  Branches     8185     8185              
==========================================
+ Hits        50283    51496    +1213     
+ Misses      22999    21786    -1213     
  Partials     2103     2103              
Flag Coverage Δ
hive 53.19% <100.00%> (ø)
mysql 78.96% <100.00%> (+<0.01%) ⬆️
postgres 79.03% <100.00%> (+<0.01%) ⬆️
presto 53.12% <100.00%> (ø)
python 82.83% <100.00%> (+3.32%) ⬆️
sqlite 77.56% <100.00%> (+<0.01%) ⬆️
unit 53.11% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 92.02% <100.00%> (ø)

... and 89 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro villebro changed the title chore(thumbnails): change default executor chore(thumbnails): change default executor to logged in user Jan 20, 2023
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 22, 2023
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 7114bba into apache:master May 17, 2023
31 checks passed
@villebro villebro deleted the villebro/thumbnails-default branch May 17, 2023 17:32
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants