Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable new dataset creation flow II #22835

Merged
merged 29 commits into from
Feb 1, 2023
Merged

feat: Enable new dataset creation flow II #22835

merged 29 commits into from
Feb 1, 2023

Commits on Feb 1, 2023

  1. optimized setDatasets call

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    5c5e211 View commit details
    Browse the repository at this point in the history

  2. Remove console.log

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    e822b94 View commit details
    Browse the repository at this point in the history

  3. Create dataset polish/bug fix

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    9ec9c99 View commit details
    Browse the repository at this point in the history

  4. Make defaultPageSize a const and move emptyStateComponent into src/co… 

    …mponents/EmptyState
    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    7dc42ef View commit details
    Browse the repository at this point in the history

  5. Change all add dataset entrances to use new create page

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    2a42fda View commit details
    Browse the repository at this point in the history

  6. Cancel now redirects to the previous page

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    047e25e View commit details
    Browse the repository at this point in the history

  7. Create dataset returns user to dataset list

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    fc65ffe View commit details
    Browse the repository at this point in the history

  8. Delete AddDatasetModal

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    6538236 View commit details
    Browse the repository at this point in the history

  9. Fix tests

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    7e167c2 View commit details
    Browse the repository at this point in the history

  10. Use useHistory instead of window.location.href

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    d2fbc98 View commit details
    Browse the repository at this point in the history

  11. Address Cody's review comments

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    ee40bdb View commit details
    Browse the repository at this point in the history

  12. Add dangerToasts to error handling

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    64749a2 View commit details
    Browse the repository at this point in the history

  13. Fix lint

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    a31a141 View commit details
    Browse the repository at this point in the history

  14. Fix useEffect warnings and autosetting db from local storage, add tra… 

    …nslations, change window.location.href redirect to use history.push()
    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    b03efda View commit details
    Browse the repository at this point in the history

  15. fix lint

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    00feed8 View commit details
    Browse the repository at this point in the history

  16. Add path back into error message

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    3b0d32a View commit details
    Browse the repository at this point in the history

  17. Fix DatabaseModal test by mocking useHistory hook

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    c3673ec View commit details
    Browse the repository at this point in the history

  18. Add table_name query to /chart/add/ redirect

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    585b915 View commit details
    Browse the repository at this point in the history

  19. Change text on footer create button

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    fbd2f2d View commit details
    Browse the repository at this point in the history

  20. Add filter by database ID to rison in queryParams

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    c31363e View commit details
    Browse the repository at this point in the history

  21. Remove user-selected db from local storage when db is deleted

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    de429a9 View commit details
    Browse the repository at this point in the history

  22. Fix bugs

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    211d8a1 View commit details
    Browse the repository at this point in the history

  23. Fix bug: Create dataset disabled in topnav + menu

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    dff5f07 View commit details
    Browse the repository at this point in the history

  24. Better solution for top nav create dataset disabled bug

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    ee0f2f0 View commit details
    Browse the repository at this point in the history

  25. Fix bug: already existing datasets are not marked as "already exists"… 

    … in dataset creation page
    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    4bafc1a View commit details
    Browse the repository at this point in the history

  26. Fix CREATE_DATASET_TEXT and tooltip in footer, add todo note to histo… 

    …ry functionality in DatabaseModal
    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    e80adab View commit details
    Browse the repository at this point in the history

  27. Merge branch 'master' into lyndsi/enable-dataset-creation-fixed

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    9fa7ccb View commit details
    Browse the repository at this point in the history

  28. Fix rebase

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    fcf1546 View commit details
    Browse the repository at this point in the history

  29. Fix LeftPanel test

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    bb94687 View commit details
    Browse the repository at this point in the history