-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Show clickable link instead of code-formatting #23115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix! One thing worth considering is moving the backticks inside the link (probably the original intent). But this is a matter of taste.
In the top part of the paragraph, mysqlclient is not formatted in backtics either, so I propose the same format is used for the part that I updated. |
Makes sense, will merge once CI passes |
@pylipp there was an issue on CI which has now been fixed. Are you able to rebase your PR? Thanks! |
Just opened a PR pulling in this commit - hopefully it's mergable, and @pylipp will still get the credit. Happy to close that one if you'd rather rebase this... if not, I'll close this one when the other merges. Thanks either way, and join us in #documentation on Slack if you want to contribute to more documentation touchups! |
Closing this since we haven't heard back and the copy of it has been merged. Thank you for the alleyoop! |
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION