Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Show clickable link instead of code-formatting #23115

Closed
wants to merge 1 commit into from

Conversation

pylipp
Copy link
Contributor

@pylipp pylipp commented Feb 18, 2023

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix! One thing worth considering is moving the backticks inside the link (probably the original intent). But this is a matter of taste.

@pylipp
Copy link
Contributor Author

pylipp commented Feb 20, 2023

LGTM, thanks for the fix! One thing worth considering is moving the backticks inside the link (probably the original intent). But this is a matter of taste.

In the top part of the paragraph, mysqlclient is not formatted in backtics either, so I propose the same format is used for the part that I updated.

@villebro
Copy link
Member

In the top part of the paragraph, mysqlclient is not formatted in backtics either, so I propose the same format is used for the part that I updated.

Makes sense, will merge once CI passes

@pylipp pylipp changed the title Docs: Show clickable link instead of code-formatting docs: Show clickable link instead of code-formatting Feb 20, 2023
@villebro
Copy link
Member

@pylipp there was an issue on CI which has now been fixed. Are you able to rebase your PR? Thanks!

@rusackas
Copy link
Member

Just opened a PR pulling in this commit - hopefully it's mergable, and @pylipp will still get the credit. Happy to close that one if you'd rather rebase this... if not, I'll close this one when the other merges. Thanks either way, and join us in #documentation on Slack if you want to contribute to more documentation touchups!

@rusackas
Copy link
Member

rusackas commented Jul 7, 2023

Closing this since we haven't heard back and the copy of it has been merged. Thank you for the alleyoop!

@rusackas rusackas closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants