Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schedule query option showing up #23386

Merged

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Mar 15, 2023

SUMMARY

The "schedule query" option in SQL Lab is showing up even when the feature is not configured... I suspect because of this change: https://github.com/apache/superset/pull/20256/files

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen Shot 2023-03-15 at 3 08 44 PM

After:

Screen Shot 2023-03-15 at 3 07 39 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@nytai
Copy link
Member

nytai commented Mar 18, 2023

I was testing the 2.1 rc last night and I noticed the same, took me a while to figure it out. I ended up setting SCHEDULED_QUERIES = None in the config file

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #23386 (6ea4d2b) into master (b0d83e8) will increase coverage by 0.00%.
The diff coverage is 78.57%.

❗ Current head 6ea4d2b differs from pull request most recent head 8d8e36c. Consider uploading reports for the commit 8d8e36c to get more accurate results

@@           Coverage Diff           @@
##           master   #23386   +/-   ##
=======================================
  Coverage   67.63%   67.63%           
=======================================
  Files        1908     1908           
  Lines       73716    73729   +13     
  Branches     7989     7989           
=======================================
+ Hits        49856    49867   +11     
- Misses      21812    21814    +2     
  Partials     2048     2048           
Flag Coverage Δ
javascript 53.82% <81.25%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...frontend/src/SqlLab/components/SqlEditor/index.jsx 56.68% <0.00%> (ø)
...c/components/Chart/DrillDetail/DrillDetailPane.tsx 75.00% <ø> (ø)
...tersConfigModal/FiltersConfigForm/ColumnSelect.tsx 77.14% <ø> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 55.17% <ø> (-4.49%) ⬇️
.../dataset/AddDataset/EditDataset/UsageTab/index.tsx 90.47% <ø> (ø)
superset/config.py 91.78% <ø> (ø)
superset/tasks/thumbnails.py 36.36% <0.00%> (-2.67%) ⬇️
superset-frontend/src/components/Table/index.tsx 71.42% <60.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 64.50% <100.00%> (+0.44%) ⬆️
... and 5 more

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@betodealmeida betodealmeida added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Mar 20, 2023
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@betodealmeida betodealmeida merged commit d01cf43 into apache:master Mar 21, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels merge-if-green If approved and tests are green, please go ahead and merge it for me size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants