Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): show_native_filters leftover #23389

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix(dashboard): show_native_filters leftover #23389

merged 1 commit into from
Mar 17, 2023

Conversation

betodealmeida
Copy link
Member

SUMMARY

#23228 removed show_native_filters from dashboards, but it can still be present in exports from older versions. When the key is present, the dashboard is imported correctly, but can't be updated because the schema of json_metadata is now invalid.

This PR addresses the problem by removing the field on dashboard import. Additionally, for those dashboards that have already been imported with the field, it relaxes the metadata schema to allow updates when show_native_filters is present, removing it before processing the metadata.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #23389 (0069cca) into master (ec6318b) will increase coverage by 0.13%.
The diff coverage is 88.46%.

❗ Current head 0069cca differs from pull request most recent head 6571f13. Consider uploading reports for the commit 6571f13 to get more accurate results

@@            Coverage Diff             @@
##           master   #23389      +/-   ##
==========================================
+ Coverage   67.44%   67.58%   +0.13%     
==========================================
  Files        1907     1907              
  Lines       73493    73537      +44     
  Branches     7976     7980       +4     
==========================================
+ Hits        49571    49702     +131     
+ Misses      21873    21787      -86     
+ Partials     2049     2048       -1     
Flag Coverage Δ
hive 52.75% <27.02%> (?)
mysql 78.45% <94.59%> (+0.01%) ⬆️
postgres 78.52% <94.59%> (+0.01%) ⬆️
presto 52.68% <27.02%> (-0.02%) ⬇️
python 82.30% <94.59%> (+0.19%) ⬆️
sqlite 78.55% <94.59%> (+1.57%) ⬆️
unit 52.48% <29.72%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-core/src/hooks/useChangeEffect/useChangeEffect.ts 100.00% <ø> (ø)
...hooks/useComponentDidMount/useComponentDidMount.ts 100.00% <ø> (ø)
...oks/useComponentDidUpdate/useComponentDidUpdate.ts 100.00% <ø> (ø)
...src/hooks/useElementOnScreen/useElementOnScreen.ts 100.00% <ø> (ø)
...erset-ui-core/src/hooks/usePrevious/usePrevious.ts 100.00% <ø> (ø)
...re/src/hooks/useTruncation/useCSSTextTruncation.ts 100.00% <ø> (ø)
...c/hooks/useTruncation/useChildElementTruncation.ts 100.00% <ø> (ø)
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 40.00% <ø> (ø)
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 35.71% <ø> (ø)
...harts/src/Timeseries/Regular/Line/controlPanel.tsx 33.33% <ø> (ø)
... and 45 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@betodealmeida betodealmeida merged commit 0222139 into master Mar 17, 2023
@eschutho
Copy link
Member

@betodealmeida alternatively, could we bump the export version and create a new import version?

jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Mar 20, 2023
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Mar 20, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the sh68647 branch March 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2023.11 size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants