feat(postgresql): dynamic schema

[betodealmeida]

SUMMARY

Builds on #23385. Renames the adjust_database_uri method to adjust_engine_params and makes it accept connect_args as well, so we can implement dynamic schema in Postgres. In addition, the method also takes an optional catalog, so in the future we can implement proper catalog support.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before, when using Postgres the SQL Lab schema dropdown is not used to run the query. Note that in the example below information_schema is selected, but the query actually runs in the public schema:

With this PR:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #23401 (f465853) into master (42e8d1b) will increase coverage by 1.64%.
The diff coverage is 80.00%.

❗ Current head f465853 differs from pull request most recent head 2db69f2. Consider uploading reports for the commit 2db69f2 to get more accurate results

@@            Coverage Diff             @@
##           master   #23401      +/-   ##
==========================================
+ Coverage   65.96%   67.61%   +1.64%     
==========================================
  Files        1907     1907              
  Lines       73590    73611      +21     
  Branches     7982     7982              
==========================================
+ Hits        48546    49772    +1226     
+ Misses      22996    21791    -1205     
  Partials     2048     2048              

Flag	Coverage Δ
hive	52.73% <36.92%> (-0.02%)	⬇️
mysql	78.40% <67.69%> (+<0.01%)	⬆️
postgres	78.46% <67.69%> (-0.04%)	⬇️
presto	52.65% <38.46%> (-0.02%)	⬇️
python	82.32% <80.00%> (+3.39%)	⬆️
sqlite	76.97% <67.69%> (?)
unit	52.51% <58.46%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engine_specs/snowflake.py	66.86% <14.28%> (+19.27%)	⬆️
superset/db_engine_specs/drill.py	88.88% <40.00%> (+33.33%)	⬆️
superset/dashboards/commands/importers/v1/utils.py	85.00% <50.00%> (+6.79%)	⬆️
superset/models/core.py	89.74% <77.77%> (-0.36%)	⬇️
superset/dashboards/schemas.py	98.98% <83.33%> (-0.50%)	⬇️
superset/db_engine_specs/base.py	90.80% <100.00%> (+8.75%)	⬆️
superset/db_engine_specs/hive.py	87.79% <100.00%> (+1.01%)	⬆️
superset/db_engine_specs/mysql.py	98.79% <100.00%> (+9.63%)	⬆️
superset/db_engine_specs/postgres.py	97.01% <100.00%> (+5.95%)	⬆️
superset/db_engine_specs/presto.py	88.05% <100.00%> (+1.25%)	⬆️

... and 81 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[eschutho]

@betodealmeida what do you think will be the impact of this change on any custom db engine specs that have been added to Superset instances?

[eschutho]

oh, nm, I see how you covered this below.

[eschutho]

I noticed that in some of the class overrides, catalog and schema have kwargs with defaults instead of positional arguments. Do we want to be consistent?

[betodealmeida]

Ah, good point, let me add defaults here.

[eschutho]

Looks great! I just had the one question about args vs kwargs, but not a blocker.