Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lang): update messages.po(t) and add missing German translations #23402

Merged
merged 8 commits into from
Apr 7, 2023

Conversation

hbruch
Copy link
Contributor

@hbruch hbruch commented Mar 16, 2023

SUMMARY

This PR

  • updates messages.pot file and derived language dependent *.po files (generated via ./scripts/babel_update.sh)
  • adds missing German translations to the .../de/.../messages.po file

NOTE: this PR does not (yet) include the messages.json files, as I'm hesitant to include them with this PR. They could be generated in the build process and probably should not be checked in anyway. Please let me know, if the de/.../messages.json or all languages files should be part of this PR.

NOTE FURTHER, that there remain some not-yet-localized messages, e.g. the last-modified times in the following screen shot, which are not created localized via helpers.py/changed_on_humanized and created_on_humanized

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #23402 (2eef3c3) into master (a823033) will not change coverage.
The diff coverage is n/a.

❗ Current head 2eef3c3 differs from pull request most recent head ddb69bb. Consider uploading reports for the commit ddb69bb to get more accurate results

@@           Coverage Diff           @@
##           master   #23402   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files        1918     1918           
  Lines       74151    74151           
  Branches     8052     8052           
=======================================
  Hits        50212    50212           
  Misses      21886    21886           
  Partials     2053     2053           
Flag Coverage Δ
hive 52.72% <ø> (ø)
mysql 78.53% <ø> (ø)
postgres 78.60% <ø> (ø)
presto 52.65% <ø> (ø)
python 82.44% <ø> (ø)
sqlite 77.11% <ø> (ø)
unit 52.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nytai
Copy link
Member

nytai commented Mar 17, 2023

CI is failing, can you please address?

@hbruch
Copy link
Contributor Author

hbruch commented Mar 19, 2023

Babel generates unnecessary empty lines just before EOF (see python-babel/babel#799). For now, I removed them manually.

Either a comment should be added to CONTRIBUTING.md or scripts/update_babel.sh be enhanced to chop off this EOF newline, as long as the above cited issue is not fixed.

@nytai
Copy link
Member

nytai commented Mar 20, 2023

messages.json should be part of this PR FYI.

Either a comment should be added to CONTRIBUTING.md or scripts/update_babel.sh be enhanced to chop off this EOF newline, as long as the above cited issue is not fixed.

That sounds reasonable, can you do one of those?

@hbruch
Copy link
Contributor Author

hbruch commented Mar 22, 2023

This PR now

  • updates messages.pot file and derived language dependent *.po files (generated via ./scripts/babel_update.sh), as well as messages.json files (generated via ./scripts/po2json.sh)
  • adds missing German translations to the .../de/.../messages.po file
  • fixes wrongly named pt/messages.po file
  • in .scripts/babel_update.sh chops off at EOF for po/pot files

@nytai I see the latest failing tests as not related to my changes. Could you confirm, please? In case tests are flaky, is there anything which could be done about this?

@hbruch
Copy link
Contributor Author

hbruch commented Apr 7, 2023

I'm currently a bit disappointed by flaky tests blocking review/merging. Please correct me, if I'm wrong @rusackas, but the failing test is not related to this PR, is it?

@villebro
Copy link
Member

villebro commented Apr 7, 2023

@hbruch I restarted the flaked tests, 🤞 they'll pass this time

@rusackas
Copy link
Member

rusackas commented Apr 7, 2023

Restarted the python integration tests... we'll get this thing through!!!

@@ -54,4 +54,17 @@ pybabel update \
-d superset/translations \
--ignore-obsolete

# Chop off last blankline from po/pot files, see https://github.com/python-babel/babel/issues/799
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the extra line causing a problem (e.g. linting issues) or is this just cleanup to feel good about things? Only asking because the other solution might be to tweak the linting rule for these files. This seems fine, I'm just curious. ¯\_(ツ)_/¯

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplicated empty line was reported by a linting rule, indeed.

@rusackas rusackas merged commit 389b29f into apache:master Apr 7, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants