chore: Dataset specific MetadataBar

[kgabryje]

SUMMARY

Metadata bar component for dataset will be used in Drill to detail modal and in Drill by modal. In order to DRY the code, this PR moves the boilerplate for constructing a dataset specific metadata bar to a separate hook.
In addition, this PR adds a storybook for the new not-generic metadata bar.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Verify that the metadata bar in drill to detail modal works like before

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[michael-s-molina]

Thank you for the PR @kgabryje. I left some comments.

[michael-s-molina]

Can we mock useApiV1Resource instead of introducing a new dependency (storybook-addon-mock) and configuring SupersetClient?

[kgabryje]

Do you have a reference on how to mock a return value of a function in storybook?

[michael-s-molina]

There's an addon to mock imports but that would also introduce a new dependency. It seems it's not very straightforward though. While thinking about the problem, I'm not sure if a storybook for this hook is highly valuable given that the MetadataBar component already has one that displays the dataset information. I see a test file much for valuable as the objective of the hook is to assemble the correct information from the server and transform data to be displayed. If you asked me, I would delete the storybook and the new dependency and add a test file with the different combinations of server responses (no description, no creator, no owners, etc). I'll leave the decision to you as it's not a blocker for me.

[kgabryje]

Added UT. Like you said, to mock a dependency we'd still need an addon.
I'd rather keep the addon for mocking API responses as I think it opens a possibility to write stories for more complex components and features.

[codecov]

Codecov Report

Merging #23429 (63ab375) into master (b077314) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 63ab375 differs from pull request most recent head d5e927a. Consider uploading reports for the commit d5e927a to get more accurate results

@@           Coverage Diff           @@
##           master   #23429   +/-   ##
=======================================
  Coverage   67.64%   67.65%           
=======================================
  Files        1908     1909    +1     
  Lines       73739    73743    +4     
  Branches     7988     7988           
=======================================
+ Hits        49879    49888    +9     
  Misses      21814    21814           
+ Partials     2046     2041    -5     

Flag	Coverage Δ
javascript	53.84% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...c/components/Chart/DrillDetail/DrillDetailPane.tsx	75.32% <100.00%> (+0.32%)	⬆️
...res/datasets/metadataBar/useDatasetMetadataBar.tsx	100.00% <100.00%> (ø)
superset/db_engine_specs/base.py	90.86% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

LGTM. Thank you for the added test!