Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add DRILL_BY feature flag #23430

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Mar 20, 2023

SUMMARY

Drill by will initially (for the time of development and testing the feature) be hidden behind a DRILL_BY feature flag.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #23430 (fe6f8c3) into master (b0d83e8) will decrease coverage by 1.78%.
The diff coverage is n/a.

❗ Current head fe6f8c3 differs from pull request most recent head 153b4df. Consider uploading reports for the commit 153b4df to get more accurate results

@@            Coverage Diff             @@
##           master   #23430      +/-   ##
==========================================
- Coverage   67.63%   65.86%   -1.78%     
==========================================
  Files        1908     1908              
  Lines       73716    73716              
  Branches     7989     7989              
==========================================
- Hits        49856    48551    -1305     
- Misses      21812    23117    +1305     
  Partials     2048     2048              
Flag Coverage Δ
hive ?
mysql 78.45% <ø> (ø)
postgres 78.51% <ø> (ø)
presto ?
python 78.64% <ø> (-3.66%) ⬇️
sqlite 77.02% <ø> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
superset/config.py 91.78% <ø> (ø)

... and 91 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas
Copy link
Member

Might want to add it in the right place in FEATURE_FLAGS.md for good measure ;)

@kgabryje
Copy link
Member Author

Might want to add it in the right place in FEATURE_FLAGS.md for good measure ;)

Good call! But I'd rather add it to documentation once the feature is ready to be used, so that no one enables it just to find some dummy components 😉

@kgabryje kgabryje merged commit 7ef06b0 into apache:master Mar 20, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants