Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow setting ingress hosts directly through yaml #23446

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

paulinjo
Copy link
Contributor

@paulinjo paulinjo commented Mar 21, 2023

SUMMARY
Fixes #23445

This PR adds the ability to configure ingress hosts as a raw block of YAML

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS
Set ingress.extraHostsRaw to a valid yaml configuration in the values file

ex:

ingress:
  extraHostsRaw:
    - host: superset.myhost.com
      http:
        paths:
          - path: /
            pathType: Prefix
            backend:
              service:
                name: ssl-redirect
                port:
                  name: use-annotation
          - path: /*
            pathType: ImplementationSpecific
            backend:
              service:
                name: superset
                port:
                  name: http

Deploy using Helm
Observe the ingress is created with the specified path configuration.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in [SIP-59] Proposal for Database migration standards #13351)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@request-info
Copy link

request-info bot commented Mar 21, 2023

We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the title or description empty.

@request-info request-info bot added the need:more-info Requires more information from author label Mar 21, 2023
@paulinjo paulinjo force-pushed the fix/helm_ingress_paths branch 2 times, most recently from 5f2dc99 to aa34ee9 Compare March 21, 2023 20:45
@paulinjo paulinjo changed the title All setting ingress hosts directly through yaml Allow setting ingress hosts directly through yaml Mar 21, 2023
@paulinjo paulinjo marked this pull request as draft March 21, 2023 20:47
@paulinjo paulinjo changed the title Allow setting ingress hosts directly through yaml Fix: Allow setting ingress hosts directly through yaml Mar 21, 2023
@paulinjo paulinjo changed the title Fix: Allow setting ingress hosts directly through yaml fix: Allow setting ingress hosts directly through yaml Mar 21, 2023
@paulinjo paulinjo marked this pull request as ready for review March 21, 2023 21:24
@craig-rueda
Copy link
Member

Looks like big changes in the README. Maybe something with the version of helm-docs you're using?

@paulinjo
Copy link
Contributor Author

Looks like big changes in the README. Maybe something with the version of helm-docs you're using?

I think pycharm did some reformatting of it's own while I was working. Should be just the new docs now.

@paulinjo paulinjo force-pushed the fix/helm_ingress_paths branch 2 times, most recently from 46cb90d to 065e560 Compare March 21, 2023 21:57
@rusackas rusackas merged commit 499754a into apache:master Mar 22, 2023
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:more-info Requires more information from author size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow full configuration of ingress hosts via helm
4 participants