fix: Removes Redux state mutations - iteration 2 #23535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23535 +/- ##
==========================================
+ Coverage 67.63% 67.71% +0.08%
==========================================
Files 1910 1916 +6
Lines 73747 74018 +271
Branches 7988 8039 +51
==========================================
+ Hits 49879 50124 +245
- Misses 21826 21845 +19
- Partials 2042 2049 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9 tasks
justinpark
reviewed
Apr 4, 2023
| export default React.memo(FiltersConfigModal); | ||
| export default React.memo( | ||
| connect(null, dispatch => | ||
| bindActionCreators({ updateCascadeParentIds }, dispatch), |
There was a problem hiding this comment.
how about useDispatch() instead of this classic connect way since it's already FC.
There was a problem hiding this comment.
Great idea! Done.
michael-s-molina
commented
Apr 4, 2023
...ontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx
Outdated
Show resolved
Hide resolved
justinpark
approved these changes
Apr 5, 2023
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This iteration removes Redux state mutations from the codebase to allow us to merge #23460 without disrupting the development workflow.
TESTING INSTRUCTIONS
1 - Pull changes from #23460 to enable the immutabilityMiddleware
2 - Add or remove a native filter
3 - You shouldn't see any errors related to state mutation
ADDITIONAL INFORMATION