Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allow logs to show error levels for ssh tunnel #23536

Merged
merged 3 commits into from
Mar 30, 2023
Merged

chore: allow logs to show error levels for ssh tunnel #23536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
399a933
allow logs to show error levels
hughhhh Mar 30, 2023
6041931
ok
hughhhh Mar 30, 2023
aebca34
show logs
hughhhh Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion superset/extensions/ssh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
# under the License.

import importlib
import logging
from io import StringIO
from typing import TYPE_CHECKING

Expand Down Expand Up @@ -53,8 +54,9 @@ def create_tunnel(
params = {
"ssh_address_or_host": (ssh_tunnel.server_address, ssh_tunnel.server_port),
"ssh_username": ssh_tunnel.username,
"remote_bind_address": (url.host, url.port), # bind_port, bind_host
"remote_bind_address": (url.host, url.port),
"local_bind_address": (self.local_bind_address,),
"debug_level": logging.getLogger("flask_appbuilder").level,
}

if ssh_tunnel.password:
Expand Down
2 changes: 1 addition & 1 deletion tests/integration_tests/csv_upload_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,4 +513,4 @@ def test_import_parquet(mock_event_logger):

with test_db.get_sqla_engine_with_context() as engine:
data = engine.execute(f"SELECT * from {PARQUET_UPLOAD_TABLE}").fetchall()
assert data == [("john", 1), ("paul", 2), ("max", 3), ("bob", 4)]
assert data == [("max", 3), ("bob", 4), ("john", 1), ("paul", 2)]