Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): undefined issue_codes on query error #23549

Merged

Conversation

justinpark
Copy link
Member

SUMMARY

The query execution can be failed without issue_codes which throws the undefined error on error_detail mapping operation.
Screenshot 2023-03-31 at 4 02 29 PM

This commit includes the hotfix for the case.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No error thrown.

TESTING INSTRUCTIONS

Query an unauthorized dataset and check the error message.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

cc: @john-bodley @ktmud @michael-s-molina

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #23549 (22234c2) into master (b52efe0) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 22234c2 differs from pull request most recent head 9965493. Consider uploading reports for the commit 9965493 to get more accurate results

@@           Coverage Diff           @@
##           master   #23549   +/-   ##
=======================================
  Coverage   67.70%   67.70%           
=======================================
  Files        1914     1914           
  Lines       73960    73960           
  Branches     8029     8029           
=======================================
  Hits        50076    50076           
  Misses      21838    21838           
  Partials     2046     2046           
Flag Coverage Δ
javascript 53.94% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 64.50% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@justinpark justinpark merged commit bd0609d into apache:master Apr 2, 2023
justinpark added a commit to airbnb/superset-fork that referenced this pull request Apr 5, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants