Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Cross filters badge for cols with verbose names #23576

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Apr 4, 2023

SUMMARY

Fixes regression introduced in #23509 that caused the filters badge not to appear if cross filter was applied on a column with verbose name.
Bonus - some minor perf/rerenders improvements in FiltersBadge component

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before (no badge next to pivot table):

image

After:

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @Always-prog

@kgabryje kgabryje requested a review from geido April 4, 2023 15:54
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #23576 (eaa22da) into master (a4d4084) will increase coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head eaa22da differs from pull request most recent head 05d64ec. Consider uploading reports for the commit 05d64ec to get more accurate results

@@           Coverage Diff           @@
##           master   #23576   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files        1916     1916           
  Lines       74017    74014    -3     
  Branches     8041     8039    -2     
=======================================
- Hits        50122    50121    -1     
+ Misses      21845    21844    -1     
+ Partials     2050     2049    -1     
Flag Coverage Δ
javascript 53.95% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../nativeFilters/FilterBar/CrossFilters/selectors.ts 9.09% <0.00%> (-0.91%) ⬇️
...rc/dashboard/components/nativeFilters/selectors.ts 58.26% <ø> (+0.90%) ⬆️
...nd/src/dashboard/components/FiltersBadge/index.tsx 85.71% <100.00%> (+1.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit 9d2f43d into apache:master Apr 4, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants