Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(saved_queries): wrong enum for object_type of saved_query #23611

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

akzarma
Copy link
Contributor

@akzarma akzarma commented Apr 6, 2023

SUMMARY

Fixes #23610
There is no "saved_query" enum value of object_type for saved queries as such. it should be "query" instead as it can be seen in ObjectTypes class.

BEFORE SCREENSHOTS

Screenshot 2023-04-06 at 4 51 32 PM

AFTER

  • Saved queries list loads fine

TESTING INSTRUCTIONS

  1. Setup Postgres as backend db (as the default sqlite db doesn't really strictly checks the enum type of object_type)
  2. Go to "Saved queries" page
  3. The list should load fine.

ADDITIONAL INFORMATION

  • Has associated issue: Invalid assignment of ObjectType in saved_query list API #23610
  • Required feature flags: TAGGING_SYSTEM
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@akzarma akzarma changed the title fix(saved_queries) wrong enum for object_type of saved_query fix(saved_queries): wrong enum for object_type of saved_query Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #23611 (4ed9eec) into master (c5eecc7) will not change coverage.
The diff coverage is n/a.

❗ Current head 4ed9eec differs from pull request most recent head 45698a5. Consider uploading reports for the commit 45698a5 to get more accurate results

@@           Coverage Diff           @@
##           master   #23611   +/-   ##
=======================================
  Coverage   67.72%   67.72%           
=======================================
  Files        1916     1916           
  Lines       74051    74051           
  Branches     8040     8040           
=======================================
  Hits        50153    50153           
  Misses      21850    21850           
  Partials     2048     2048           
Flag Coverage Δ
hive 52.75% <ø> (ø)
mysql 78.49% <ø> (ø)
postgres 78.57% <ø> (ø)
presto 52.68% <ø> (ø)
python 82.41% <ø> (ø)
sqlite 77.07% <ø> (ø)
unit 52.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/components/Datasource/ChangeDatasourceModal.tsx 78.68% <ø> (ø)
...ponents/ReportModal/HeaderReportDropdown/index.tsx 67.50% <ø> (ø)
...src/dashboard/components/PropertiesModal/index.tsx 64.03% <ø> (ø)
...d/src/explore/components/PropertiesModal/index.tsx 50.53% <ø> (ø)
...erset-frontend/src/pages/AlertReportList/index.tsx 59.64% <ø> (ø)
superset-frontend/src/pages/AllEntities/index.tsx 0.00% <ø> (ø)
...t-frontend/src/pages/AnnotationLayerList/index.tsx 68.05% <ø> (ø)
...perset-frontend/src/pages/AnnotationList/index.tsx 69.35% <ø> (ø)
superset-frontend/src/pages/ChartList/index.tsx 55.31% <ø> (ø)
...erset-frontend/src/pages/CssTemplateList/index.tsx 66.66% <ø> (ø)
... and 14 more

... and 55 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Antonio-RiveroMartnez Antonio-RiveroMartnez merged commit e8f32c4 into apache:master Apr 10, 2023
@akzarma akzarma deleted the patch-2 branch April 18, 2023 10:28
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2023.13 size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid assignment of ObjectType in saved_query list API
4 participants