Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support further drill by in the modal #23615

Merged
merged 6 commits into from
Apr 12, 2023

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Apr 6, 2023

SUMMARY

Before, user could only drill by once, from the original chart. This PR implements further drilling in the drill by modal. In drill by modal, only drill by action is available - drill to detail and cross filtering is not available.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-04-07.at.13.33.08.mov

TESTING INSTRUCTIONS

  1. Enable DRILL_BY ff
  2. Add a supported chart with groupby to a dashboard
  3. Drill by a column
  4. In the drill by modal, right click on a series to further drill by
  5. The result of further group by should render in the same modal
  6. The columns available for drilling should NOT contain columns that already were used for drilling before

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

useEffect(() => {
setChartDataResult(undefined);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #23615 (c52814d) into master (a5b6ccc) will increase coverage by 0.07%.
The diff coverage is 84.48%.

❗ Current head c52814d differs from pull request most recent head 82013ed. Consider uploading reports for the commit 82013ed to get more accurate results

@@            Coverage Diff             @@
##           master   #23615      +/-   ##
==========================================
+ Coverage   67.94%   68.02%   +0.07%     
==========================================
  Files        1918     1919       +1     
  Lines       73890    73929      +39     
  Branches     8058     8066       +8     
==========================================
+ Hits        50204    50288      +84     
+ Misses      21625    21574      -51     
- Partials     2061     2067       +6     
Flag Coverage Δ
javascript 54.06% <84.48%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-ui-core/src/chart/components/SuperChart.tsx 100.00% <ø> (ø)
...et-frontend/src/components/Chart/ChartRenderer.jsx 50.60% <ø> (ø)
superset-frontend/src/dashboard/styles.ts 100.00% <ø> (ø)
...mponents/Chart/ChartContextMenu/useContextMenu.tsx 78.57% <78.57%> (ø)
...tend/src/components/Chart/DrillBy/DrillByModal.tsx 83.05% <84.00%> (+6.30%) ⬆️
...onents/Chart/ChartContextMenu/ChartContextMenu.tsx 76.19% <88.88%> (ø)
.../src/components/Chart/DrillBy/DrillByMenuItems.tsx 92.53% <88.88%> (+8.16%) ⬆️
...tend/src/components/Chart/DrillBy/DrillByChart.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit 587e775 into apache:master Apr 12, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants