Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error on Cypress test #23617

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes the Cypress error affecting master.

cypress/integration/dashboard/editmode.test

AssertionError: Timed out retrying after 8000ms: 
Expected to find element: `[data-test=chart-card]`, but never found it.

TESTING INSTRUCTIONS

All E2E tests should pass.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #23617 (7c11afd) into master (8d14420) will not change coverage.
The diff coverage is n/a.

❗ Current head 7c11afd differs from pull request most recent head 4a0a879. Consider uploading reports for the commit 4a0a879 to get more accurate results

@@           Coverage Diff           @@
##           master   #23617   +/-   ##
=======================================
  Coverage   67.68%   67.68%           
=======================================
  Files        1918     1918           
  Lines       74133    74133           
  Branches     8052     8052           
=======================================
  Hits        50178    50178           
  Misses      21902    21902           
  Partials     2053     2053           
Flag Coverage Δ
javascript 53.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 8ef49a5 into apache:master Apr 6, 2023
michael-s-molina added a commit to airbnb/superset-fork that referenced this pull request Apr 7, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants