Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Makes "Add to dashboard" in Save chart modal paginated #23634

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Changes "Add to dashboard" in Save chart modal to use the async Select with pagination enabled.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-04-10.at.11.46.13.mov

TESTING INSTRUCTIONS

Make sure there's no regression and that the "Add to dashboard" Select loads the values using paginated queries.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina
Copy link
Member Author

@jinghua-qa Can you help me and make sure there's no regression?

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #23634 (b363302) into master (b613167) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

❗ Current head b363302 differs from pull request most recent head 4683cf9. Consider uploading reports for the commit 4683cf9 to get more accurate results

@@            Coverage Diff             @@
##           master   #23634      +/-   ##
==========================================
- Coverage   67.71%   67.70%   -0.02%     
==========================================
  Files        1918     1918              
  Lines       74157    74151       -6     
  Branches     8053     8047       -6     
==========================================
- Hits        50219    50204      -15     
- Misses      21885    21894       +9     
  Partials     2053     2053              
Flag Coverage Δ
javascript 53.87% <33.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-frontend/src/explore/actions/saveModalActions.js 97.01% <ø> (-1.74%) ⬇️
...rset-frontend/src/explore/components/SaveModal.tsx 34.78% <33.33%> (-3.19%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@geido
Copy link
Member

geido commented Apr 13, 2023

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://54.213.228.129:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. It would be good to have QA confirm as well. Thanks!

@michael-s-molina michael-s-molina merged commit d6b6d9e into apache:master Apr 18, 2023
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

michael-s-molina added a commit to airbnb/superset-fork that referenced this pull request Apr 20, 2023
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Apr 26, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants