Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Zero values on Dual Line axis bounds #23649

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fix a bug that prevented a user from using zero values on Dual Line chart axis bounds.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-04-11.at.14.20.56.mov
Screen.Recording.2023-04-11.at.14.16.58.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #23649 (2e7c56a) into master (825006d) will increase coverage by 0.15%.
The diff coverage is 77.14%.

❗ Current head 2e7c56a differs from pull request most recent head d8eed40. Consider uploading reports for the commit d8eed40 to get more accurate results

@@            Coverage Diff             @@
##           master   #23649      +/-   ##
==========================================
+ Coverage   67.93%   68.08%   +0.15%     
==========================================
  Files        1918     1920       +2     
  Lines       73891    73984      +93     
  Branches     8058     8092      +34     
==========================================
+ Hits        50199    50374     +175     
+ Misses      21633    21539      -94     
- Partials     2059     2071      +12     
Flag Coverage Δ
javascript 54.10% <76.97%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...nd/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js 0.00% <ø> (ø)
...s/plugin-chart-echarts/src/Timeseries/constants.ts 100.00% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 57.27% <0.00%> (-1.07%) ⬇️
...tend/plugins/plugin-chart-echarts/src/constants.ts 100.00% <ø> (ø)
...tend/plugins/plugin-chart-echarts/src/controls.tsx 76.00% <ø> (ø)
...ugins/preset-chart-xy/src/components/Line/Line.tsx 0.00% <0.00%> (ø)
...preset-chart-xy/src/utils/createMarginSelector.tsx 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (ø)
...frontend/src/SqlLab/components/SqlEditor/index.jsx 58.60% <ø> (+1.91%) ⬆️
... and 19 more

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor suggestion (??) but it looks okay

@michael-s-molina michael-s-molina merged commit d66e6e6 into apache:master Apr 14, 2023
23 checks passed
michael-s-molina added a commit to airbnb/superset-fork that referenced this pull request Apr 20, 2023
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Apr 26, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants