Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): Revert "rendering performance regression (#23653)" #23671

Merged

Conversation

justinpark
Copy link
Member

SUMMARY

Found the regression by #23653 when running a query by keyboard shortcut
This reverts commit a5b6ccc.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark justinpark changed the title Revert "fix(sqllab): rendering performance regression (#23653)" fix(sqllab): Revert "rendering performance regression (#23653)" Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #23671 (98b3296) into master (b35b5a6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 98b3296 differs from pull request most recent head fd0974e. Consider uploading reports for the commit fd0974e to get more accurate results

@@            Coverage Diff             @@
##           master   #23671      +/-   ##
==========================================
- Coverage   68.08%   68.08%   -0.01%     
==========================================
  Files        1920     1920              
  Lines       73990    73991       +1     
  Branches     8092     8092              
==========================================
- Hits        50379    50374       -5     
- Misses      21540    21548       +8     
+ Partials     2071     2069       -2     
Flag Coverage Δ
javascript 54.09% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/SqlEditor/index.jsx 56.68% <0.00%> (-1.92%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 40bf1a5 into apache:master Apr 13, 2023
25 of 26 checks passed
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Apr 26, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants