Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Database modal parameter inputs persisting after modal closed and reopened #23686

Conversation

jfrag1
Copy link
Member

@jfrag1 jfrag1 commented Apr 14, 2023

SUMMARY

This PR makes the metadata parameter and engine parameter inputs controlled as the others on this modal are. Without this fix, the ace editor initial default value would not be cleared when switching between databases.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

In the following examples, Connection A actually does have engine parameters, but connection B does not.
Before:
db_modal_before

After:
db_modal_after

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #23686 (7f50d95) into master (240b292) will not change coverage.
The diff coverage is n/a.

❗ Current head 7f50d95 differs from pull request most recent head 860cdb1. Consider uploading reports for the commit 860cdb1 to get more accurate results

@@           Coverage Diff           @@
##           master   #23686   +/-   ##
=======================================
  Coverage   68.09%   68.09%           
=======================================
  Files        1922     1922           
  Lines       74041    74041           
  Branches     8101     8101           
=======================================
  Hits        50419    50419           
  Misses      21551    21551           
  Partials     2071     2071           
Flag Coverage Δ
javascript 54.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../features/databases/DatabaseModal/ExtraOptions.tsx 70.37% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eschutho eschutho merged commit 3d10296 into apache:master Apr 17, 2023
24 checks passed
@eschutho eschutho deleted the jack/fix-db-modal-params-switching-between-dbs branch April 17, 2023 16:33
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Apr 17, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2023.15 size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants