Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add loading state to sqllab save/overwrite dataset modal #23697

Conversation

jfrag1
Copy link
Member

@jfrag1 jfrag1 commented Apr 14, 2023

SUMMARY

Overwriting datasets in particular can take a long time to run since it makes a request to PUT /api/v1/datasets/{id}?override_columns=true, which will execute the updated query on the DB. Requests that can take this long should have a loading indicator to let the user know something is happening and not broken.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
dataset_overwrite_before

After:
dataset_overwrite_after

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #23697 (ceb6cd1) into master (b39edc1) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

❗ Current head ceb6cd1 differs from pull request most recent head 4a0421c. Consider uploading reports for the commit 4a0421c to get more accurate results

@@            Coverage Diff             @@
##           master   #23697      +/-   ##
==========================================
- Coverage   66.30%   66.29%   -0.01%     
==========================================
  Files        1922     1922              
  Lines       74048    74054       +6     
  Branches     8104     8104              
==========================================
+ Hits        49094    49095       +1     
- Misses      22882    22887       +5     
  Partials     2072     2072              
Flag Coverage Δ
javascript 54.12% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 50.00% <16.66%> (-2.28%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eschutho eschutho merged commit 2a01aa6 into apache:master Apr 18, 2023
@eschutho eschutho deleted the jack/add-loading-state-to-save/overwrite-dataset branch April 18, 2023 17:00
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants