Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api v1): Deprecate superset/override_role_permissions endpoint #23714

Conversation

jfrag1
Copy link
Member

@jfrag1 jfrag1 commented Apr 17, 2023

SUMMARY

This endpoint is not called from client side code at all, so this endpoint should be able to be safely deprecated and removed in 3.0.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@jfrag1 jfrag1 changed the title chore: Deprecate override_role_permissions endpoint chore(api v1): Deprecate superset/override_role_permissions endpoint Apr 17, 2023
@@ -207,7 +207,6 @@ class SupersetSecurityManager( # pylint: disable=too-many-public-methods
}

ADMIN_ONLY_PERMISSIONS = {
"can_override_role_permissions",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only removing since I noticed it was duplicated a couple lines below

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #23714 (437eae5) into master (810f52b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 437eae5 differs from pull request most recent head 10b0d59. Consider uploading reports for the commit 10b0d59 to get more accurate results

@@           Coverage Diff           @@
##           master   #23714   +/-   ##
=======================================
  Coverage   68.09%   68.10%           
=======================================
  Files        1922     1922           
  Lines       74046    74047    +1     
  Branches     8104     8104           
=======================================
+ Hits        50420    50427    +7     
+ Misses      21552    21545    -7     
- Partials     2074     2075    +1     
Flag Coverage Δ
hive 53.18% <100.00%> (+<0.01%) ⬆️
mysql 79.21% <100.00%> (+<0.01%) ⬆️
postgres 79.29% <100.00%> (+<0.01%) ⬆️
presto 53.09% <100.00%> (+<0.01%) ⬆️
python 83.14% <100.00%> (+<0.01%) ⬆️
sqlite 77.79% <100.00%> (+<0.01%) ⬆️
unit 53.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/SqlEditor/index.jsx 58.28% <ø> (+1.60%) ⬆️
.../features/databases/DatabaseModal/ExtraOptions.tsx 70.37% <ø> (ø)
superset/security/manager.py 95.96% <ø> (ø)
superset/views/core.py 75.31% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eschutho eschutho merged commit 8bd4322 into apache:master Apr 18, 2023
@eschutho eschutho deleted the jack/deprecate-override-role-permissions-endpoint branch April 18, 2023 18:09
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants