Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enforce URI query params with a specific for MySQL #23723

Merged
merged 3 commits into from Apr 18, 2023

Conversation

dpgaspar
Copy link
Member

SUMMARY

Adds a new db_engine_spec parameter called enforce_uri_query_params so that we can enforce specific parameters for specific engines. Also enforces the local infile for MySQL

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dpgaspar dpgaspar changed the title Fix/mysql infile enforce feat: add enforce URI query params with a specific for MySQL Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #23723 (ea31162) into master (c197bf9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ea31162 differs from pull request most recent head 7b61a48. Consider uploading reports for the commit 7b61a48 to get more accurate results

@@           Coverage Diff           @@
##           master   #23723   +/-   ##
=======================================
  Coverage   68.10%   68.10%           
=======================================
  Files        1922     1922           
  Lines       74046    74049    +3     
  Branches     8104     8104           
=======================================
+ Hits        50426    50429    +3     
  Misses      21545    21545           
  Partials     2075     2075           
Flag Coverage Δ
hive 53.18% <40.00%> (+<0.01%) ⬆️
mysql 79.21% <100.00%> (+<0.01%) ⬆️
postgres 79.29% <100.00%> (+<0.01%) ⬆️
presto 53.09% <40.00%> (+<0.01%) ⬆️
python 83.15% <100.00%> (+<0.01%) ⬆️
sqlite 77.79% <100.00%> (+<0.01%) ⬆️
unit 53.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/base.py 90.80% <100.00%> (+0.01%) ⬆️
superset/db_engine_specs/mysql.py 98.82% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpgaspar dpgaspar requested a review from villebro April 18, 2023 15:59
@dpgaspar dpgaspar merged commit 0ad6c87 into apache:master Apr 18, 2023
25 checks passed
@dpgaspar dpgaspar deleted the fix/mysql-infile-enforce branch April 18, 2023 16:07
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Apr 20, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v2.1 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants