Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Drill by error management #23724

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

kgabryje
Copy link
Member

SUMMARY

This PR adds error toasts if following scenarios fail:

  • loading columns from dataset in context menu
  • loading chart data for rendering drill by chart/table (+ Alert banner)
  • loading form_data_key to generate Explore URL for Edit chart button

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@lilykuang lilykuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DrillByModal test needs to be updated other than that everything LGTM

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #23724 (f86f5bf) into master (c197bf9) will increase coverage by 0.01%.
The diff coverage is 71.69%.

❗ Current head f86f5bf differs from pull request most recent head 198b3b2. Consider uploading reports for the commit 198b3b2 to get more accurate results

@@            Coverage Diff             @@
##           master   #23724      +/-   ##
==========================================
+ Coverage   68.10%   68.11%   +0.01%     
==========================================
  Files        1922     1922              
  Lines       74046    74082      +36     
  Branches     8104     8107       +3     
==========================================
+ Hits        50426    50460      +34     
  Misses      21545    21545              
- Partials     2075     2077       +2     
Flag Coverage Δ
javascript 54.18% <68.08%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/reducers/sqlLab.js 35.86% <0.00%> (-1.21%) ⬇️
superset/security/manager.py 95.96% <ø> (ø)
superset/sql_parse.py 96.49% <ø> (ø)
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 50.00% <16.66%> (-2.28%) ⬇️
.../src/components/Chart/DrillBy/DrillByMenuItems.tsx 91.30% <50.00%> (-1.24%) ⬇️
...tend/src/components/Chart/DrillBy/DrillByModal.tsx 81.11% <80.00%> (+0.38%) ⬆️
...d/src/SqlLab/components/QueryAutoRefresh/index.tsx 94.59% <94.11%> (+35.97%) ⬆️
superset-frontend/src/SqlLab/actions/sqlLab.js 64.67% <100.00%> (+0.17%) ⬆️
...erset-frontend/src/SqlLab/components/App/index.jsx 83.33% <100.00%> (ø)
superset-frontend/src/utils/common.js 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit 818a1d4 into apache:master Apr 18, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants