Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): copy change submitted through BugHerd #23725

Merged
merged 1 commit into from Apr 21, 2023

Conversation

rusackas
Copy link
Member

SUMMARY

Tackling ticket #22 from BugHerd

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member Author

@sfirke take a look if you have a moment.

@sfirke
Copy link
Contributor

sfirke commented Apr 18, 2023

test

Copy link
Contributor

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #23725 (4852108) into master (2a01aa6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23725   +/-   ##
=======================================
  Coverage   68.09%   68.09%           
=======================================
  Files        1922     1922           
  Lines       74056    74056           
  Branches     8104     8104           
=======================================
  Hits        50431    50431           
  Misses      21550    21550           
  Partials     2075     2075           
Flag Coverage Δ
hive 53.18% <ø> (ø)
javascript 54.14% <ø> (ø)
mysql 79.21% <ø> (ø)
postgres 79.29% <ø> (ø)
presto 53.09% <ø> (ø)
python 83.15% <ø> (ø)
sqlite 77.79% <ø> (ø)
unit 53.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit a3c971c into master Apr 21, 2023
52 checks passed
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@rusackas rusackas deleted the copy-change-ticket-22 branch May 11, 2023 16:55
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants