feat(adhoc-column): add resize option #23748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23748 +/- ##
==========================================
- Coverage 68.12% 68.08% -0.04%
==========================================
Files 1922 1923 +1
Lines 74104 74140 +36
Branches 8101 8103 +2
==========================================
Hits 50481 50481
- Misses 21545 21581 +36
Partials 2078 2078
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
/testenv up |
|
@villebro Container image not yet published for this PR. Please try again when build is complete. |
|
@villebro Ephemeral environment creation failed. Please check the Actions logs for details. |
kgabryje
reviewed
Apr 20, 2023
...rset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Apr 20, 2023
...rset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Apr 20, 2023
...rset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Apr 20, 2023
...rset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx
Outdated
Show resolved
Hide resolved
villebro
force-pushed
the
villebro/resize-adhoc-column
branch
from
45a0f11
to
14dacf8
Compare
sebastianliebscher
pushed a commit
to sebastianliebscher/superset
that referenced
this pull request
Apr 28, 2023
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds resizing to the adhoc column popover, and is based on what's currently used in the metric and filter popovers. This is often needed when writing custom SQL expressions. In addition, the height multiplier of 2 is removed from the metric and filter popovers, as it only makes intuitive sense when the popover placement is set to
left, in which case the popover grows both upwards and downwards. Since we let AntD decide which placement to use, it makes more sense to not apply multiplier, as the popover often grows out of bounds quickly, causing weird side-effects when the placement changes. This also felt unintuitive, as the vertical movement was doubled, as opposed to horizontal movement, which was not multiplied.AFTER
Now the adhoc column popover is resizable:
Also, the removed multiplier makes the resize action be in line with the vertical mouse movement:
resize-after.mp4
BEFORE
Previously the adhoc column popover wasn't resizable:
Also, the multiplier caused the resize action to feel unintuitive with top placement:
resize-before.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION