Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cover empty AdvancedDataTypes internet_address and internet_port #23756

Merged
merged 2 commits into from
May 11, 2023

Conversation

sebastianliebscher
Copy link
Contributor

SUMMARY

This PR adds two tests for AdvancedDataTypes internet_address and internet_port when no value was passed in.

TESTING INSTRUCTIONS

pytest or ./scripts/tests/run.sh

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #23756 (2595c13) into master (e3719a1) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 2595c13 differs from pull request most recent head 25f1733. Consider uploading reports for the commit 25f1733 to get more accurate results

@@            Coverage Diff             @@
##           master   #23756      +/-   ##
==========================================
+ Coverage   68.13%   68.20%   +0.07%     
==========================================
  Files        1941     1941              
  Lines       75304    75304              
  Branches     8166     8166              
==========================================
+ Hits        51308    51362      +54     
+ Misses      21907    21853      -54     
  Partials     2089     2089              
Flag Coverage Δ
hive 53.18% <ø> (?)
mysql ?
postgres 78.98% <ø> (ø)
presto 53.10% <ø> (ø)
python 82.72% <ø> (+0.14%) ⬆️
sqlite 77.51% <ø> (ø)
unit 53.01% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro villebro merged commit c8beaab into apache:master May 11, 2023
26 checks passed
@EugeneTorap EugeneTorap deleted the test_type_tests branch May 11, 2023 10:37
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants