Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drill by modal resizing #23757

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

kgabryje
Copy link
Member

SUMMARY

When user used drill by feature in World Map chart, the modal would start growing vertically.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2023-04-20.at.18.40.05.mov

After:

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #23757 (3b3a5b2) into master (764c3c9) will increase coverage by 0.21%.
The diff coverage is n/a.

❗ Current head 3b3a5b2 differs from pull request most recent head 6390ba5. Consider uploading reports for the commit 6390ba5 to get more accurate results

@@            Coverage Diff             @@
##           master   #23757      +/-   ##
==========================================
+ Coverage   67.87%   68.09%   +0.21%     
==========================================
  Files        1924     1923       -1     
  Lines       74381    74140     -241     
  Branches     8106     8103       -3     
==========================================
- Hits        50486    50482       -4     
+ Misses      21818    21580     -238     
- Partials     2077     2078       +1     
Flag Coverage Δ
javascript 54.11% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/components/Chart/DrillBy/DrillByChart.tsx 100.00% <ø> (ø)

... and 34 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje force-pushed the fix/drill-by-worldmap-modal branch from cb16304 to 6390ba5 Compare April 21, 2023 14:31
@kgabryje kgabryje merged commit 2f7229c into apache:master Apr 21, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants