Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(actions): Fix for Chromatic action using actions/checkout@v3 #23759

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

rusackas
Copy link
Member

SUMMARY

The Chromatic action is broken on master CI builds. The error indicates that it's due to a recent PR where the checkout action was bumped from v1 to v3. The error leads to this documentation, so this PR makes an update accordingly.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Merge (if CI passes here) and monitor CI on master

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #23759 (05b5900) into master (818a1d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23759   +/-   ##
=======================================
  Coverage   68.09%   68.09%           
=======================================
  Files        1922     1922           
  Lines       74075    74075           
  Branches     8100     8100           
=======================================
  Hits        50445    50445           
  Misses      21553    21553           
  Partials     2077     2077           
Flag Coverage Δ
hive 53.18% <ø> (ø)
javascript 54.15% <ø> (ø)
mysql 79.21% <ø> (ø)
postgres 79.29% <ø> (ø)
presto 53.10% <ø> (ø)
python 83.15% <ø> (ø)
sqlite 77.79% <ø> (ø)
unit 53.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit 295975d into master Apr 21, 2023
@rusackas rusackas deleted the chromatic-action-checkout-fix branch April 21, 2023 03:47
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants