Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [chart power query] error show when user input column with x-axis #23776

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Apr 21, 2023

SUMMARY

Users aren't able to set x-axis for when in explore and ds = query. This was a bug brought in by consolidating how we generate queries text in explore. Totally forgot to implement adhoc_column_to_sqla function for Query objects

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #23776 (405250b) into master (4d97ece) will increase coverage by 0.01%.
The diff coverage is 42.85%.

❗ Current head 405250b differs from pull request most recent head 43d2fcc. Consider uploading reports for the commit 43d2fcc to get more accurate results

@@            Coverage Diff             @@
##           master   #23776      +/-   ##
==========================================
+ Coverage   67.85%   67.87%   +0.01%     
==========================================
  Files        1924     1924              
  Lines       74381    74383       +2     
  Branches     8106     8105       -1     
==========================================
+ Hits        50471    50485      +14     
+ Misses      21833    21822      -11     
+ Partials     2077     2076       -1     
Flag Coverage Δ
hive 52.92% <42.85%> (-0.01%) ⬇️
mysql 78.73% <42.85%> (?)
postgres 78.81% <42.85%> (-0.01%) ⬇️
presto 52.83% <42.85%> (-0.01%) ⬇️
python 82.64% <42.85%> (+0.03%) ⬆️
sqlite 77.31% <42.85%> (-0.01%) ⬇️
unit 52.72% <42.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/components/Chart/DrillBy/DrillByModal.tsx 73.00% <ø> (-0.08%) ⬇️
superset/views/sql_lab/views.py 63.81% <ø> (ø)
superset/models/sql_lab.py 78.40% <42.85%> (-1.11%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hughhhh hughhhh merged commit 669e180 into master Apr 22, 2023
51 checks passed
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the cpq-x-axis-fix branch March 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants