docs: Add description of standard Superset roles #23795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
approved these changes
Apr 25, 2023
|
Tagging a few other people who might want to lay eyes on this before merging, but this looks great (and hugely valuable) to me. Kicked off CI... nag me if it fails or some silly reason and I don't notice :D |
|
The linter seems to be having problems with the trailing whitespace in the markdown. We might be able to dial down the rigor here for markdown files, but in the meantime, I'd suggest either trimming these by hand really quick, or running |
|
I removed the only whitespace I could find. I hope this fixes it |
rusackas
reviewed
Apr 27, 2023
RESOURCES/STANDARD_ROLES.md
Outdated
| |can dashboard permalink on Superset|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O| | ||
| |can grant guest token on SecurityRestApi|:heavy_check_mark:|O|O|O| | ||
| |can read on AdvancedDataType|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O| | ||
| |can read on EmbeddedDashboard|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O| |
There was a problem hiding this comment.
Suggested change
| |can read on EmbeddedDashboard|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O| | |
| |can read on EmbeddedDashboard|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O| | |
There was a problem hiding this comment.
Now it's the end-of-file fixer. I think it wants a newline.
|
I put the newline there, let's see |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds a table which describes the permissions included in the standard Superset roles.
This is largely based on 2.0.1 permissions and needs to be checked.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION