Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump python version to 3.11 in Dockerfile #23804

Closed
wants to merge 1 commit into from

Conversation

tooptoop4
Copy link
Contributor

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member

Pinging @villebro and @EugeneTorap as I believe you've wrangled with this in the past, and know the perils and pitfalls here better than most :)

@EugeneTorap
Copy link
Contributor

EugeneTorap commented Apr 27, 2023

Hi @tooptoop4!
We use the minimum supported python version in the Dockerfile. It's 3.8 version.
But we can push a docker image with python 3.11 - look at #22770 PR how to do it!
@villebro @dpgaspar can we rid 3.8 & 3.9 PY versions of in superset 3.0 and use only 3.10 & 3.11 PY versions? In superset 4.0 we'll rid 3.10 PY version of and will use only 3.11 & 3.12 PY versions. What do you think?

@villebro
Copy link
Member

@EugeneTorap I agree, we should bump to 3.10 as the official version. Would you be up for making the changes?

@EugeneTorap
Copy link
Contributor

@villebro Yes, I want to do it!

@mdeshmu
Copy link
Contributor

mdeshmu commented May 11, 2023

I have raised the PR to add support for 3.11

@EugeneTorap
Copy link
Contributor

EugeneTorap commented May 11, 2023

@mdeshmu We use the minimum supported version of Python in Dockerfile! It's Py3.9 because a lot of drivers don't have support Py3.10 & Py3.11 (for example: PyHive don't have support the new versions of python)

@mdeshmu
Copy link
Contributor

mdeshmu commented May 11, 2023

I am not changing the default image version which supports 3.9. I just added the ability to create additional images with 3.11 so that we can use it with Superset's code base.
Talking of database drivers, Many of the drivers we use, do support Py 3.11. For e.g. pyathena, redshift-connector, pyscopg2 and many more.

@EugeneTorap
Copy link
Contributor

@mdeshmu, I agree with you but @sebastianliebscher and me are working on updating the minimum PY version of the superset from 3.9 to 3.10 and use only 3.10 & 3.11 here.

@mdeshmu
Copy link
Contributor

mdeshmu commented May 12, 2023

I didn't clearly understand your last comment.
I saw @sebastianliebscher's PR in which he has made python 3.9 as default and added support for 3.10 additional images.
I have just extended that work and added support for 3.11 additional images in this PR.

@EugeneTorap
Copy link
Contributor

@mdeshmu Yes, we will soon have a PR for Bump to Python3.10 where we only use 3.10 and 3.11 PY for docker images.

@mdeshmu
Copy link
Contributor

mdeshmu commented May 12, 2023

Would that be with Superset 3.0 release or earlier ?

@EugeneTorap
Copy link
Contributor

Yeap, we plan to use only PY 3.10 & 3.11 in Superset 3.0

@EugeneTorap
Copy link
Contributor

If you have a slack account in apache/superset you can join #server-refactoring channel and help us to fix PyHive for PY 3.10

@rusackas
Copy link
Member

@EugeneTorap @villebro @tooptoop4 is this PR still relevant? It looks like we're still on 3.9.

@mistercrunch
Copy link
Member

Closing this in favor or #24112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants