Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to import CSV as datasource #2381

Closed
wants to merge 57 commits into from
Closed

Allow users to import CSV as datasource #2381

wants to merge 57 commits into from

Conversation

SalehHindi
Copy link

Fixes #381 which was started by @Ryan4815.

Any comments, suggestions appreciated.

Wood and others added 30 commits November 14, 2016 13:00
Testing gitlab remote repo
71665f7
@Ryan4815
test commit
fe81595
@Ryan4815
Merge branch 'master' of https://github.com/airbnb/superset
c16bd58
@Ryan4815
Merge branch 'master' of https://github.com/airbnb/superset
668f443
@Ryan4815
Merge branch 'master' of https://github.com/airbnb/superset
6ddcb22
Merge remote-tracking branch 'origin/master' into csv-import
452e9df
@Ryan4815
Merge branch 'master' of https://github.com/airbnb/superset
87937e5
trying out various ways of uploading xls/csv with flask
3f3ab33
Merge remote-tracking branch 'origin/master' into csv-import
39c2aba
@Ryan4815
revert previous changes
9ffbf9a
@Ryan4815
Add CSV button placed on database page
dcb0f14
@Ryan4815
Changed upload csv to use same layout/template as import dashboards
a539090
@Ryan4815
Starting to add csv to db form (to expose panda api)
b5222fc
@Ryan4815
CsvToDatabaseView updated to include most of the pandas api read_csv …
38762b0 
…fields.
@Ryan4815
Exposed the pandas .to_sql API in the upload csv form. Removed the se…
ae1e9d5 
…parate upload page.
@Ryan4815
Merge branch 'master' of https://github.com/airbnb/superset
ff37bd7
@Ryan4815
File select part of csvtodatabaseview form
0474253
@Ryan4815
Merge branch 'master' of https://github.com/airbnb/superset
fb186f2
@Ryan4815
If cause to set the header column to row 0 if name is none
0dc844e
@Ryan4815
Merge remote-tracking branch 'origin/master' into csv-import
f0e534d
@Ryan4815
Used flask-babel lazy_gettext to ready the new strings for translation.
96ebb82
@Ryan4815
Moved Csv form from views.py to forms.py and removed unused imports
7425b65
@Ryan4815
Changed BooleanField to use BetterBooleanField
3781a60
@Ryan4815
Added FAQ entry on uploading csv
1b4d62f
@Ryan4815
Merge branch 'master' of https://github.com/airbnb/superset
8ebf1f8
@Ryan4815
Merge remote-tracking branch 'origin/master' into csv-import
38c54c3
Merge Ryan4815's fork into my fork
1623bf8
Fix merge conflict
2c7eed7
Add tests to CSV-import
3f8ecfb
Change the default of replace to append
e560c5c
@mistercrunch
Copy link
Member

Please fix the 31 codeclimate issues and make sure the build passes

@coveralls
Copy link

coveralls commented Sep 8, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-1.4%) to 67.668% when pulling 61a217c on SalehHindi:csv-import into 3dfdde1 on apache:master.

@timifasubaa timifasubaa mentioned this pull request Sep 27, 2017
Closed
This was referenced Oct 9, 2017
Closed
Closed
Merged
@timifasubaa
Copy link
Contributor

timifasubaa commented Feb 9, 2018 •
edited
Loading

We can close this since the feature now exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx left review comments

@mistercrunch mistercrunch mistercrunch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@SalehHindi @mistercrunch @coveralls @timifasubaa @xrmx @graceguo-supercat @Ryan4815