Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update bleach #23839

Closed

Conversation

sebastianliebscher
Copy link
Contributor

@sebastianliebscher sebastianliebscher commented Apr 27, 2023

SUMMARY

Update bleach to latest 6.0.0 version. Also, heads-up on bleach is deprecated and will only receive security fixes. #23838

TESTING INSTRUCTIONS

pytest or ./scripts/tests/run.sh

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #23839 (41e83c3) into master (5f03549) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 41e83c3 differs from pull request most recent head 76d6d87. Consider uploading reports for the commit 76d6d87 to get more accurate results

@@           Coverage Diff           @@
##           master   #23839   +/-   ##
=======================================
  Coverage   56.76%   56.76%           
=======================================
  Files        1937     1937           
  Lines       74929    74929           
  Branches     8133     8133           
=======================================
  Hits        42534    42534           
  Misses      30311    30311           
  Partials     2084     2084           
Flag Coverage Δ
hive 53.01% <100.00%> (ø)
presto 52.92% <100.00%> (ø)
python 59.41% <100.00%> (ø)
unit 52.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/reports/notifications/email.py 75.00% <100.00%> (ø)
superset/utils/core.py 65.09% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EugeneTorap
Copy link
Contributor

Hi @sebastianliebscher! Thanks for this PR!
But I've prepared a new #23862 PR to use nh3 lib instead of bleach.
Can you review my PR?

@dpgaspar
Copy link
Member

superseded by #23862

@dpgaspar dpgaspar closed this Apr 28, 2023
@sebastianliebscher sebastianliebscher deleted the chore-bleach branch April 28, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants