Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Slovenian translation update #23873

Merged
merged 1 commit into from
Jan 29, 2024
Merged

chore: Slovenian translation update #23873

merged 1 commit into from
Jan 29, 2024

Conversation

dkrat7
Copy link
Contributor

@dkrat7 dkrat7 commented Apr 28, 2023

SUMMARY

This PR updates the Slovenian translation files:

  • translation strings updated/inserted (new features are translated)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot from 2023-02-25 23-53-18

TESTING INSTRUCTIONS

Change language settings to Slovenian, check translations.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29633e7) 69.14% compared to head (be7ee8b) 69.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #23873   +/-   ##
=======================================
  Coverage   69.14%   69.14%           
=======================================
  Files        1946     1946           
  Lines       75989    75989           
  Branches     8479     8479           
=======================================
  Hits        52544    52544           
  Misses      21266    21266           
  Partials     2179     2179           
Flag Coverage Δ
hive 53.68% <ø> (ø)
mysql 78.07% <ø> (+0.02%) ⬆️
postgres 78.17% <ø> (ø)
presto 53.63% <ø> (ø)
python 82.86% <ø> (ø)
sqlite 76.83% <ø> (ø)
unit 55.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"5 minute": ["5 minute"],
"5 minutes": ["5 minutes"],
"5 second": ["5 second"],
"5 seconds": ["5 seconds"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do so many strings in this PR seem like they're being translated back into English?

Copy link
Contributor Author

@dkrat7 dkrat7 May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, but these are mostly time deltas for chart Advanced analytics which supports natural language (ISO 8601 durations) and time filter granularities which support natural language also.

I thought it would be confusing for users if these are translated, because natural language input has to be in English and these strings also serve as input examples. That's is why I translated those back in English (I didn't want to leave the fields empty because in the future I (or somebody else) could forget about this and translate it.

(Maybe I made some mistakes also. Sometimes it is hard to find translation string context, there are almost 4 thousand strings)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2023-05-04 00-15-13

@dkrat7 dkrat7 changed the title chore: Slovenian translation update (2.1.0) chore: Slovenian translation update Jul 29, 2023
@dkrat7
Copy link
Contributor Author

dkrat7 commented Jul 29, 2023

I updated translations with the latest master. Is there any chance this PR is merged?
If there are any technical issues left I can try to fix them.
I suppose another problem is lack of reviewers familiar with the Slovenian language in the Superset team.

@dkrat7 dkrat7 closed this Jan 2, 2024
@dkrat7 dkrat7 reopened this Jan 2, 2024
@rusackas rusackas merged commit 8ca541c into apache:master Jan 29, 2024
63 checks passed
eschutho pushed a commit to preset-io/superset that referenced this pull request Jan 31, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants