New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check sqlalchemy_uri #23901
fix: check sqlalchemy_uri #23901
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23901 +/- ##
==========================================
+ Coverage 66.34% 68.10% +1.75%
==========================================
Files 1938 1939 +1
Lines 74972 75010 +38
Branches 8141 8154 +13
==========================================
+ Hits 49739 51084 +1345
+ Misses 23154 21843 -1311
- Partials 2079 2083 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 88 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I find regex based allow/denylists are practically always better 👍
(cherry picked from commit e5f512e)
(cherry picked from commit e5f512e)
(cherry picked from commit e5f512e)
(cherry picked from commit e5f512e)
(cherry picked from commit e5f512e)
SUMMARY
Updates check_sqlalchemy_uri
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION