Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check sqlalchemy_uri #23901

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented May 2, 2023

SUMMARY

Updates check_sqlalchemy_uri

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #23901 (8a3e0a3) into master (31d3359) will increase coverage by 1.75%.
The diff coverage is 65.57%.

❗ Current head 8a3e0a3 differs from pull request most recent head 8815d4b. Consider uploading reports for the commit 8815d4b to get more accurate results

@@            Coverage Diff             @@
##           master   #23901      +/-   ##
==========================================
+ Coverage   66.34%   68.10%   +1.75%     
==========================================
  Files        1938     1939       +1     
  Lines       74972    75010      +38     
  Branches     8141     8154      +13     
==========================================
+ Hits        49739    51084    +1345     
+ Misses      23154    21843    -1311     
- Partials     2079     2083       +4     
Flag Coverage Δ
hive 53.01% <33.33%> (?)
mysql 78.80% <73.33%> (+<0.01%) ⬆️
postgres 78.88% <73.33%> (+<0.01%) ⬆️
presto 52.92% <33.33%> (?)
python 82.67% <96.66%> (+3.66%) ⬆️
sqlite 77.39% <73.33%> (+<0.01%) ⬆️
unit 52.81% <73.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/legacy-plugin-chart-calendar/src/controlPanel.ts 50.00% <ø> (ø)
...rts/src/BigNumber/BigNumberTotal/transformProps.ts 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx 0.00% <0.00%> (ø)
...tend/src/components/Chart/DrillBy/DrillByChart.tsx 100.00% <ø> (ø)
.../components/Chart/DrillBy/useDisplayModeToggle.tsx 100.00% <ø> (ø)
...c/components/Chart/DrillBy/useResultsTableView.tsx 100.00% <ø> (ø)
...onalFormattingControl/FormattingPopoverContent.tsx 51.35% <ø> (ø)
superset/examples/supported_charts_dashboard.py 0.00% <ø> (ø)
...harts/src/BigNumber/BigNumberTotal/controlPanel.ts 30.00% <22.22%> (-70.00%) ⬇️
...s/ExploreChartPanel/useResizeDetectorByObserver.ts 62.50% <62.50%> (ø)
... and 7 more

... and 88 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/M and removed size/L labels May 2, 2023
@dpgaspar dpgaspar added the 2.1.1 label May 2, 2023
@dpgaspar dpgaspar requested a review from eschutho May 2, 2023 10:26
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I find regex based allow/denylists are practically always better 👍

@dpgaspar dpgaspar merged commit e5f512e into apache:master May 3, 2023
25 checks passed
@dpgaspar dpgaspar deleted the danielgaspar/sc-70147/security-prevent-sqllite-connections-from branch May 3, 2023 10:14
@eschutho eschutho added the v2.1 label May 12, 2023
eschutho pushed a commit to preset-io/superset that referenced this pull request May 23, 2023
eschutho pushed a commit that referenced this pull request May 23, 2023
(cherry picked from commit e5f512e)
eschutho pushed a commit that referenced this pull request May 25, 2023
(cherry picked from commit e5f512e)
eschutho pushed a commit that referenced this pull request May 31, 2023
(cherry picked from commit e5f512e)
eschutho pushed a commit that referenced this pull request Jun 13, 2023
(cherry picked from commit e5f512e)
@mistercrunch mistercrunch added 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v2.1 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants