Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrates Dual Line Chart to Mixed Chart #23910

Merged
merged 8 commits into from
Jun 8, 2023

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented May 2, 2023

SUMMARY

This PR migrates the Dual Line Chart to Mixed Chart (ECharts).

  • Removes the legacy chart code and unregisters the plugin.
  • Removes old plugin references throughout the codebase
  • Updates unit tests
  • Updates E2E tests
  • Updates the example dashboards
  • Updates translation files

AFTER SCREENSHOTS

Screenshot 2023-05-03 at 18 07 54

TESTING INSTRUCTIONS

1 - Make sure all Dual Line charts were converted to Mixed charts
2 - Make sure Dual Line is not available anymore in the viz picker
3 - Make sure that it's possible to revert the migration by executing superset db downgrade and reverting this PR

ADDITIONAL INFORMATION

1 - Make sure all Treemap (legacy) charts were converted to Treemap
2 - Make sure Treemap (legacy) is not available anymore in the viz picker
3 - Make sure that it's possible to revert the migration by executing superset db downgrade and reverting this PR

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added risk:breaking-change Issues or PRs that will introduce breaking changes hold! On hold v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels May 3, 2023
@pull-request-size pull-request-size bot added size/XL and removed size/L labels May 3, 2023
@michael-s-molina michael-s-molina marked this pull request as ready for review May 3, 2023 21:25
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #23910 (58df163) into master (af24092) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 58df163 differs from pull request most recent head 3fd5ac2. Consider uploading reports for the commit 3fd5ac2 to get more accurate results

@@            Coverage Diff             @@
##           master   #23910      +/-   ##
==========================================
+ Coverage   57.42%   57.46%   +0.03%     
==========================================
  Files        1951     1951              
  Lines       75438    75394      -44     
  Branches     8218     8218              
==========================================
+ Hits        43320    43322       +2     
+ Misses      30007    29961      -46     
  Partials     2111     2111              
Flag Coverage Δ
hive 53.53% <50.00%> (+0.04%) ⬆️
presto 53.45% <50.00%> (+0.04%) ⬆️
python 60.26% <100.00%> (+0.06%) ⬆️
unit 53.88% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js 0.00% <ø> (ø)
...end/plugins/legacy-preset-chart-nvd3/src/preset.js 0.00% <ø> (ø)
...ins/legacy-preset-chart-nvd3/src/transformProps.js 7.40% <ø> (+0.74%) ⬆️
...ponents/controls/VizTypeControl/VizTypeGallery.tsx 88.23% <ø> (ø)
...-frontend/src/visualizations/presets/MainPreset.js 100.00% <ø> (ø)
superset/examples/birth_names.py 70.00% <ø> (ø)
superset/viz.py 29.73% <ø> (+0.21%) ⬆️
...perset/migrations/shared/migrate_viz/processors.py 76.08% <100.00%> (+8.43%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving Cypress code changes... looking good, thank you for tackling all this!!

@michael-s-molina michael-s-molina merged commit f5148ef into apache:master Jun 8, 2023
29 checks passed
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels hold! On hold risk:breaking-change Issues or PRs that will introduce breaking changes size/XXL 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants