chore(helm): Declare missing properties #23926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craig-rueda
approved these changes
May 4, 2023
dpgaspar
approved these changes
May 4, 2023
|
@dnskr theres a lint issue "trim trailing whitespace" can you fix it please? |
dnskr
force-pushed
the
declare_missing_chart_properties
branch
from
9a516a2
to
03db8ff
Compare
dnskr
force-pushed
the
declare_missing_chart_properties
branch
from
03db8ff
to
3862219
Compare
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The PR declares missing properties used by the chart with empty values in
values.yaml(self-documenting improvement).The PR does not change any functionality of the chart.
Docs in
README.mdfile updated byhelm-docsutility.TESTING INSTRUCTIONS
The following command creates the same output before and after changes.
ADDITIONAL INFORMATION