Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecates viz.py #23934

Merged
merged 4 commits into from
May 4, 2023

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented May 4, 2023

SUMMARY

Deprecates all methods in viz.py.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #23934 (35c4ee8) into master (f1fa1a7) will decrease coverage by 1.71%.
The diff coverage is 100.00%.

❗ Current head 35c4ee8 differs from pull request most recent head ca2975e. Consider uploading reports for the commit ca2975e to get more accurate results

@@            Coverage Diff             @@
##           master   #23934      +/-   ##
==========================================
- Coverage   68.12%   66.41%   -1.71%     
==========================================
  Files        1941     1941              
  Lines       75073    75209     +136     
  Branches     8155     8155              
==========================================
- Hits        51141    49949    -1192     
- Misses      21849    23177    +1328     
  Partials     2083     2083              
Flag Coverage Δ
hive ?
mysql 78.90% <100.00%> (+0.07%) ⬆️
postgres 78.97% <100.00%> (+0.07%) ⬆️
presto ?
python 79.10% <100.00%> (-3.58%) ⬇️
sqlite 77.49% <100.00%> (+0.08%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/viz.py 61.32% <100.00%> (+3.02%) ⬆️

... and 91 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/L and removed size/M labels May 4, 2023
@michael-s-molina michael-s-molina merged commit b7689fb into apache:master May 4, 2023
25 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants