build: helm template to set init job annotations #23941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybudweiser
requested review from
craig-rueda,
dpgaspar and
villebro
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
craig-rueda
reviewed
May 4, 2023
| @@ -621,7 +621,9 @@ init: | |||
| - "-c" | |||
| - ". {{ .Values.configMountPath }}/superset_bootstrap.sh; . {{ .Values.configMountPath }}/superset_init.sh" | |||
| enabled: true | |||
| helmHook: true | |||
| jobAnnotations: | |||
There was a problem hiding this comment.
let's just call this key annotations
There was a problem hiding this comment.
there is another key called podAnnotations below so i kept it specific.
hooks need to go on the job annotation
Is that ok?
|
Running CI 🤞 |
ybudweiser
changed the title
|
@ybudweiser Install and run helm-docs to fix the issue in CI. |
craig-rueda
approved these changes
May 5, 2023
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Provides a flexible option for adding annotations to the init-db job. By default the existing helm hooks will be added, however a user can now replace the annotations with hooks compatible with argo cd.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
ADDITIONAL INFORMATION
Note: This removes the helm value of init.helmHook and replaces it with a more flexible option
If you have previously disabled the helmHook to continue with it disabled you will need to replace it with
init.jobAnnotations = {}