Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Comment 3.8 PY required CI checks #24002

Merged
merged 1 commit into from
May 10, 2023
Merged

chore: Comment 3.8 PY required CI checks #24002

merged 1 commit into from
May 10, 2023

Conversation

EugeneTorap
Copy link
Contributor

@EugeneTorap EugeneTorap commented May 10, 2023 •
edited
Loading

SUMMARY

Before remove 3.8 PY support and bump to 3.9 PY version in #23890 we need to comment 3.8 PY CI tests in github config file.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@EugeneTorap EugeneTorap changed the title Update PY versions of required CI checks chore: Update PY versions of required CI checks May 10, 2023
@EugeneTorap EugeneTorap mentioned this pull request May 10, 2023
Merged
villebro
villebro reviewed May 10, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree that this is the end state we want to achieve, this change will block all other PRs until the CI bump PR is merged. So if we run into trouble with it we're screwed and may need ASF help to unblock us. Let's rather remove the required 3.8 tests, leave the 3.9 ones and reintroduce the 3.8 and 3.9 ones as 3.9 and 3.10 respectively after the CI update has been merged, just to be safe.

@villebro villebro requested a review from dpgaspar May 10, 2023 12:43
@EugeneTorap EugeneTorap changed the title chore: Update PY versions of required CI checks chore: Comment 3.8 PY required CI checks May 10, 2023
@EugeneTorap EugeneTorap force-pushed the chore/update-required-status-checks-for-ci branch from 897a98f to e822761 Compare May 10, 2023 13:04
villebro
villebro approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Let's try to follow up quickly with the next step so we can re-enable the bumped workflows

@villebro villebro merged commit a357648 into apache:master May 10, 2023
@EugeneTorap EugeneTorap deleted the chore/update-required-status-checks-for-ci branch May 10, 2023 13:36
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar approved these changes

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EugeneTorap @dpgaspar @villebro @mistercrunch