Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicates of validate_adhoc_subquery #24023

Merged
merged 2 commits into from
May 12, 2023

Conversation

betodealmeida
Copy link
Member

SUMMARY

Remove duplicates of validate_adhoc_subquery.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida requested review from hughhhh and lilykuang and removed request for hughhhh May 11, 2023 18:54
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #24023 (96a6123) into master (7a55625) will increase coverage by 1.67%.
The diff coverage is 100.00%.

❗ Current head 96a6123 differs from pull request most recent head 58dee78. Consider uploading reports for the commit 58dee78 to get more accurate results

@@            Coverage Diff             @@
##           master   #24023      +/-   ##
==========================================
+ Coverage   66.54%   68.21%   +1.67%     
==========================================
  Files        1941     1941              
  Lines       75280    75259      -21     
  Branches     8168     8168              
==========================================
+ Hits        50093    51341    +1248     
+ Misses      23098    21829    -1269     
  Partials     2089     2089              
Flag Coverage Δ
hive 53.18% <100.00%> (+<0.01%) ⬆️
mysql 78.92% <100.00%> (+0.01%) ⬆️
postgres 78.99% <100.00%> (+0.01%) ⬆️
presto 53.10% <100.00%> (?)
python 82.78% <100.00%> (+3.46%) ⬆️
sqlite 77.52% <100.00%> (+0.01%) ⬆️
unit 53.05% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/sqla/models.py 87.24% <ø> (+0.81%) ⬆️
superset/models/helpers.py 69.31% <ø> (+0.61%) ⬆️
superset/connectors/sqla/utils.py 90.00% <100.00%> (-0.10%) ⬇️

... and 90 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@betodealmeida betodealmeida merged commit 7fe0ca1 into master May 12, 2023
54 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the remove_extra_validate_adhoc_subquery branch March 26, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants