Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typing and using enter to select the table on sql lab layout #24028

Merged
merged 1 commit into from
May 11, 2023

Conversation

lilykuang
Copy link
Member

SUMMARY

  • Typing and using enter to select the table, breaks sql lab layout

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • Before
    before

  • After
    after

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #24028 (18f429b) into master (7a55625) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 18f429b differs from pull request most recent head 47b09f6. Consider uploading reports for the commit 47b09f6 to get more accurate results

@@           Coverage Diff           @@
##           master   #24028   +/-   ##
=======================================
  Coverage   66.54%   66.54%           
=======================================
  Files        1941     1941           
  Lines       75280    75280           
  Branches     8168     8168           
=======================================
  Hits        50093    50093           
  Misses      23098    23098           
  Partials     2089     2089           
Flag Coverage Δ
javascript 54.52% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/components/TableSelector/index.tsx 81.08% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lilykuang lilykuang merged commit 479be86 into apache:master May 11, 2023
@lilykuang lilykuang deleted the lily/fix-table-selector branch May 11, 2023 23:06
@sadpandajoe
Copy link
Contributor

🏷️ preset:2023.19

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request May 12, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants