chore(security): Make get_database_perm/get_dataset_perm return optional

[john-bodley]

SUMMARY

Per here perms can be None and thus these return types (which could be overloaded) should be Optional[str] rather than str.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #24046 (ae638a7) into master (97482c5) will increase coverage by 0.00%.
The diff coverage is 88.88%.

❗ Current head ae638a7 differs from pull request most recent head 08547b2. Consider uploading reports for the commit 08547b2 to get more accurate results

@@           Coverage Diff           @@
##           master   #24046   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files        1941     1941           
  Lines       75261    75162   -99     
  Branches     8168     8134   -34     
=======================================
- Hits        51344    51280   -64     
+ Misses      21828    21803   -25     
+ Partials     2089     2079   -10     

Flag	Coverage Δ
hive	53.17% <33.33%> (-0.01%)	⬇️
mysql	78.93% <88.88%> (-0.01%)	⬇️
postgres	79.01% <88.88%> (-0.01%)	⬇️
presto	53.09% <33.33%> (-0.01%)	⬇️
python	82.78% <88.88%> (-0.01%)	⬇️
sqlite	77.53% <88.88%> (-0.01%)	⬇️
unit	53.04% <33.33%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...frontend/src/SqlLab/components/ResultSet/index.tsx	63.05% <ø> (+0.39%)	⬆️
...-frontend/src/components/FilterableTable/index.tsx	81.39% <ø> (+8.66%)	⬆️
superset-frontend/src/components/Table/index.tsx	71.42% <ø> (ø)
superset/security/manager.py	95.83% <88.88%> (-0.13%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[john-bodley]

@michael-s-molina apologies for the delay in responding to your comments. Regarding replacing Optional[str] with str | None, currently the superset/security/manager.py file doesn't include the,

from __future__ import annotations

import and thus this syntax is not supported. My sense/preference is that this file (alongside others) should be updated in a different PR to keep this change to a minimum.

[michael-s-molina]

LGTM