Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add extension for related DB assets on delete #24050

Merged

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented May 15, 2023

SUMMARY

Add an extension to show additional related assets when deleting a database.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Updated unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida force-pushed the database-delete-modal-extension branch 3 times, most recently from 7e19a49 to 9659fb7 Compare May 15, 2023 16:38
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #24050 (0072e5b) into master (9681d85) will increase coverage by 0.03%.
The diff coverage is 71.12%.

❗ Current head 0072e5b differs from pull request most recent head 2800e19. Consider uploading reports for the commit 2800e19 to get more accurate results

@@            Coverage Diff             @@
##           master   #24050      +/-   ##
==========================================
+ Coverage   68.18%   68.22%   +0.03%     
==========================================
  Files        1941     1942       +1     
  Lines       75241    75196      -45     
  Branches     8158     8146      -12     
==========================================
- Hits        51306    51299       -7     
+ Misses      21852    21811      -41     
- Partials     2083     2086       +3     
Flag Coverage Δ
javascript 54.52% <68.02%> (+0.03%) ⬆️
postgres ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-controls/src/shared-controls/dndControls.tsx 58.33% <ø> (ø)
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...n-chart-handlebars/src/plugin/controls/columns.tsx 15.78% <0.00%> (+0.78%) ⬆️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 66.41% <ø> (-2.12%) ⬇️
...frontend/src/SqlLab/components/ResultSet/index.tsx 63.05% <ø> (+0.39%) ⬆️
...et-frontend/src/components/TableSelector/index.tsx 81.08% <0.00%> (+2.70%) ⬆️
...ontrols/DndColumnSelectControl/DndFilterSelect.tsx 42.97% <ø> (+0.69%) ⬆️
...controls/DndColumnSelectControl/DndSelectLabel.tsx 72.72% <ø> (-2.28%) ⬇️
... and 56 more

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@betodealmeida betodealmeida merged commit fe903c3 into apache:master May 16, 2023
28 checks passed
@betodealmeida betodealmeida deleted the database-delete-modal-extension branch May 16, 2023 22:41
betodealmeida added a commit to preset-io/superset that referenced this pull request May 17, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants