Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always allow tags to be returned via the API #24060

Merged
merged 5 commits into from
May 22, 2023
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 15, 2023

SUMMARY

Going to soften the TAGGING_SYSTEM, and always allow tags to be returned regardless of the feature flag.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #24060 (4d0c91f) into master (7a55625) will increase coverage by 1.73%.
The diff coverage is 74.64%.

❗ Current head 4d0c91f differs from pull request most recent head b19888c. Consider uploading reports for the commit b19888c to get more accurate results

@@            Coverage Diff             @@
##           master   #24060      +/-   ##
==========================================
+ Coverage   66.54%   68.27%   +1.73%     
==========================================
  Files        1941     1955      +14     
  Lines       75280    75447     +167     
  Branches     8168     8215      +47     
==========================================
+ Hits        50093    51511    +1418     
+ Misses      23098    21830    -1268     
- Partials     2089     2106      +17     
Flag Coverage Δ
hive 53.32% <39.47%> (+0.13%) ⬆️
mysql 78.96% <72.69%> (+0.05%) ⬆️
postgres 79.03% <72.69%> (+0.05%) ⬆️
presto 53.24% <41.11%> (?)
python 82.84% <79.93%> (+3.52%) ⬆️
sqlite 77.57% <71.38%> (+0.06%) ⬆️
unit 53.33% <48.02%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i-core/src/color/colorSchemes/sequential/common.ts 100.00% <ø> (ø)
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...plugins/legacy-preset-chart-deckgl/src/factory.tsx 0.00% <ø> (ø)
...preset-chart-deckgl/src/layers/Heatmap/Heatmap.tsx 0.00% <0.00%> (ø)
...d/plugins/legacy-preset-chart-deckgl/src/preset.js 100.00% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 56.95% <ø> (-0.29%) ⬇️
...n-chart-handlebars/src/plugin/controls/columns.tsx 15.78% <0.00%> (+0.78%) ⬆️
...frontend/src/SqlLab/components/ResultSet/index.tsx 63.05% <ø> (+0.39%) ⬆️
... and 157 more

... and 69 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh requested a review from eschutho May 15, 2023 18:03
@@ -169,7 +169,7 @@ class RolesSchema(Schema):
class TagSchema(Schema):
id = fields.Int()
name = fields.String()
type = fields.String()
type = fields.Int()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed here? Does this map to an enum? If so, can we use fields.Enum instead?

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than what's left from Beto's comment, this lgtm.

@hughhhh hughhhh merged commit 7891cea into master May 22, 2023
54 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the hxgh-tags-400 branch March 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants