chore(trino): Bump Trino version to address an IANA time zone issue #24069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
changed the title
john-bodley
force-pushed
the
john-bodley--bump-trino
branch
from
f225049
to
62db170
Compare
Codecov Report
@@ Coverage Diff @@
## master #24069 +/- ##
=======================================
Coverage 68.22% 68.22%
=======================================
Files 1942 1942
Lines 75215 75215
Branches 8145 8145
=======================================
Hits 51318 51318
Misses 21812 21812
Partials 2085 2085
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
villebro
approved these changes
May 16, 2023
Comment on lines
-125
to
-126
| greenlet==2.0.2 | ||
| # via sqlalchemy |
There was a problem hiding this comment.
We'd really need to add linting to these requirements to make sure they're up to date. The python lint workflow would be perfect for this.
| @@ -130,7 +130,7 @@ sqlalchemy-bigquery==1.6.1 | |||
| # via apache-superset | |||
| statsd==4.0.1 | |||
| # via -r requirements/testing.in | |||
| trino==0.323.0 | |||
| trino==0.324.0 | |||
michael-s-molina
approved these changes
May 16, 2023
Oh nice, I hadn't noticed the author of said fix - congrats! 🎉 |
john-bodley
changed the title
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
May 16, 2023
…pache#24069) (cherry picked from commit 58e1bcd)
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR bumps the minimal requirement for the
python-trino-clientas, per the 0.324.0 release notes, the latest release includes a vital fix to address an IANA time zone issue.Note as part of this change I rebuilt the frozen requirements via:
which, in addition to bumping the
trinopackage, removed some legacy requirement which likely were removed in previous PRs without refreezing the requirements.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION