Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update packages for vanta FE security concerns #24106

Merged
merged 2 commits into from
May 18, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 17, 2023

SUMMARY

Fixing concerns for these security issues:
https://security.snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908 - high
GHSA-xvch-5gv4-984h

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@lilykuang lilykuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: please npm run prettier before merge

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #24106 (b2549a3) into master (fe903c3) will decrease coverage by 11.33%.
The diff coverage is 41.50%.

❗ Current head b2549a3 differs from pull request most recent head db8231a. Consider uploading reports for the commit db8231a to get more accurate results

@@             Coverage Diff             @@
##           master   #24106       +/-   ##
===========================================
- Coverage   68.31%   56.98%   -11.33%     
===========================================
  Files        1951     1951               
  Lines       75385    75412       +27     
  Branches     8185     8185               
===========================================
- Hits        51496    42976     -8520     
- Misses      21786    30333     +8547     
  Partials     2103     2103               
Flag Coverage Δ
javascript 54.70% <ø> (ø)
mysql ?
postgres ?
presto ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/api.py 50.65% <ø> (-35.20%) ⬇️
superset/dashboards/api.py 51.40% <ø> (-41.18%) ⬇️
superset/datasets/api.py 46.90% <ø> (-41.10%) ⬇️
superset/db_engine_specs/hive.py 65.31% <0.00%> (-22.19%) ⬇️
superset/db_engine_specs/trino.py 79.20% <ø> (-4.80%) ⬇️
superset/queries/api.py 80.88% <ø> (-16.18%) ⬇️
superset/db_engine_specs/ocient.py 51.26% <25.00%> (-6.03%) ⬇️
superset/models/slice.py 58.41% <25.00%> (-29.27%) ⬇️
superset/connectors/sqla/models.py 73.38% <50.00%> (-16.39%) ⬇️
superset/models/dashboard.py 48.09% <50.00%> (-30.07%) ⬇️
... and 6 more

... and 294 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh merged commit 8fb0d6e into apache:master May 18, 2023
26 checks passed
@hughhhh hughhhh deleted the hxgh-vanta-fe-concerns branch May 18, 2023 00:45
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants